Check proper error handling of the `helper.GetRepoPath`
The following discussion from !2095 (merged) should be addressed:
-
@8bitlife started a discussion: (+2 comments) I checked what
helper.GetRepoPath
does and looks like it always returnsstatus.Errorf
with proper code:codes.Internal | codes.InvalidArgument | codes.NotFound
, so we need toreturn err
here.I have found a couple of places where it is wrapped with one of
status.Errorf
,helper.ErrInvalidArgument(err)
,helper.ErrInternal(err)
.
Maybe it is a good starting point for the new issue. What do you think @zj-gitlab ?
/cc @zj-gitlab @jramsay