internal/git/safecmd_test.go spawns actual Git commands and causes havok
I think we overlooked something when setting up this test. It's a test of our git
command argument validator. The problem is, it actually spawns git
commands. Most of them are bogus and error out but there is an actual valid command in there (git config user.name jramsay
) and if you're lucky, your local Gitaly repo gets configured with that username, which is not what most people (besides @jramsay ) would want.
We should either make sure all commands that get launched during this test are harmless, or that they are no-ops. We could e.g. override the path to the git
binary.