Gitaly-Ruby wiki support: upgrade from gitlab-gollum-lib + gitlab_grit to gollum-lib + rugged
Follow-up to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22373
The grit
gem is unmaintained, and the gitlab_grit
gem is now only used by [gitlab-]gollum-lib
. Upstream gollum are looking to replace it with rugged: https://github.com/gollum/gollum/wiki/Git-adapters
I think we should look to retire the GitLab fork of gollum-lib, and gitlab_grit, entirely. This implies replacing gitlab-gollum-lib
+ gitlab_grit
in Gitaly with gollum-lib
+ rugged
, and fixing any regressions that occur as a result of this change. As part of this, we may need to get changes in gitlab-gollum-lib
merged upstream, and/or improve their Rugged adapter for git.
gitlab-ce inlines a single piece of code from gitlab-gollum-lib
: a snippet that generates a slug from a page title. There's a chance that switching between forks will cause the generated slugs to change, so we may need to introduce a "generate slug" RPC as part of this issue.
Although this issue is opened in the gitaly project, I think this should be primarily the responsibility of ~Create .