Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitaly
gitaly
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 666
    • Issues 666
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 28
    • Merge requests 28
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • gitalygitaly
  • Issues
  • #1243

Closed
Open
Created Jun 19, 2018 by Jacob Vosmaer@jacobvosmaer-gitlabOwner4 of 4 tasks completed4/4 tasks

EE Repository#upstream_branches and repository mirroring in general

Repository#upstream_branches is an EE method that calls into Gitlab::Git::RepositoryMirroring and does bad stuff.

We should also take a closer look at repository mirroring in general. There are suspicious-looking methods in https://gitlab.com/gitlab-org/gitlab-ee/blob/e07277085da57fa09bf4091a565a85fbc9141c27/lib/gitlab/git/repository_mirroring.rb and we need to be sure they only get called from gitaly-ruby, if at all.

Added 20180709: Get rid of test for remote_branches in spec/models/repository_spec.rb; remote_branches is local to gitaly-ruby. Should not be tested in the gitlab-ce/ee test suite.


Stages:

  • RPC Design: gitaly-proto!202 (diffs)

  • Server Implementation: !799 (merged)

  • ~"Client Implementation": https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6583

  • ~"Acceptance Testing": #1312 (closed)

RPC Endpoints:

  • Endpoint::Name

Known Client Routes:

  • Known client endpoints

Edited Aug 20, 2018 by Alejandro Rodríguez
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
v1.0
Milestone
v1.0 (Past due)
Assign milestone
Time tracking