Skip to content

EE Repository#upstream_branches and repository mirroring in general

Repository#upstream_branches is an EE method that calls into Gitlab::Git::RepositoryMirroring and does bad stuff.

We should also take a closer look at repository mirroring in general. There are suspicious-looking methods in https://gitlab.com/gitlab-org/gitlab-ee/blob/e07277085da57fa09bf4091a565a85fbc9141c27/lib/gitlab/git/repository_mirroring.rb and we need to be sure they only get called from gitaly-ruby, if at all.

Added 20180709: Get rid of test for remote_branches in spec/models/repository_spec.rb; remote_branches is local to gitaly-ruby. Should not be tested in the gitlab-ce/ee test suite.


Stages:

RPC Endpoints:

  • Endpoint::Name

Known Client Routes:

  • Known client endpoints

Edited by Alejandro Rodríguez
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information