Skip to content
Snippets Groups Projects
Commit 3dff901a authored by Pavlo Strokov's avatar Pavlo Strokov Committed by Paul Okstad
Browse files

Feature flag distributed_reads enabled by default

After enabling feature flag and verification of it on prod env
it shows expected results. The next step is to enable it by
default and allow a user to explicitly disable it in case of
some errors/performance problems.

Relates to: #2944
parent 3e1f8137
No related branches found
No related tags found
Loading
---
title: Enable distributed_reads feature flag by default
merge_request: 2470
author:
type: changed
......@@ -14,7 +14,7 @@ var (
// GoFetchSourceBranch enables a go implementation of FetchSourceBranch
GoFetchSourceBranch = FeatureFlag{Name: "go_fetch_source_branch", OnByDefault: false}
// DistributedReads allows praefect to redirect accessor operations to up-to-date secondaries
DistributedReads = FeatureFlag{Name: "distributed_reads", OnByDefault: false}
DistributedReads = FeatureFlag{Name: "distributed_reads", OnByDefault: true}
// GoPreReceiveHook will bypass the ruby pre-receive hook and use the go implementation
GoPreReceiveHook = FeatureFlag{Name: "go_prereceive_hook", OnByDefault: true}
// GoPostReceiveHook will bypass the ruby post-receive hook and use the go implementation
......
......@@ -222,7 +222,7 @@ func (n *Mgr) GetSyncedNode(ctx context.Context, virtualStorageName, repoPath st
return nil, fmt.Errorf("get shard for %q: %w", virtualStorageName, err)
}
if !featureflag.IsEnabled(ctx, featureflag.DistributedReads) {
if featureflag.IsDisabled(ctx, featureflag.DistributedReads) {
return shard.Primary, nil
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment