GitLab Frontend Maintainer Review Value Set
What
Define a set of Values to deliver maintainer reviews from. This is not a set of rules but rather, a guiding set of principles for maintainers to lean into for consistency in our reviews with one another, much in the same way we have values for delivering code and conduct here in GitLab: https://about.gitlab.com/handbook/values/
Why
At GitLab, we have a large selection of Front-end maintainers who strive for the highest quality when reviewing merge requests. However, due to the nature of being human, we are often subject to individual nuances that may or may not serve the overall codebase of GitLab well.
This was raised as a discussion point in the Frontend maintainer meeting by @sarahghp as to What is the ideal balance between code consistency team-to-team? Are we trying to pick too many nits in pursuit of consistency?
which evolved into a larger question of:
As a maintainer, what values should we choose to enforce in reviews, and what can be considered with more flux? Following this, with items granted more flux, how do we approach that? Do we aim for a collaborative model and encourage maintainers to share branches with authors / encourage more follow-up issues / follow-up merges, or what can be ignored as a personal preference?
Or in a more simple expression:
When does a merge warrant being blocked when evaluated against our values? And if it does, would your peer maintainers agree with this judgment.
How
Let's flesh out a selection of written values to help us with our values when maintaining merges. This would ideally live inside the GitLab handbook in the same fashion as the current GitLab values do, as it is simply a subset of values that represent how we guide ourselves during code reviews.
When
Though a lot of this would happen async on this issue or a merge, it would be good to establish 1 - 5 collaborative sync meetings to allow everyone a chance to voice their opinions and/or concerns around the ideas being put forward.
In the comments below, please use a