Alphabetizing imports/components/variables
What is the GitLab FE stance on alphabetizing imports/components? I saw a community contributor updating the order of components here, I had a good look in our docs and couldnt find anything about a preference for this, so I suggested that there was no solid reason to do this, so it should not be done.
They responded saying they were specifically asked to previously here
I’m finding it pretty frustrating getting feedback to write code in a way that suits the reviewer’s preference and I’m sure its even more frustrating for community contributors.
Is it possible we can make an agreement as a department on the preference and then ensure that we enforce that preference consistently? Is this already the case? where can i find a document list of opinions on this?
(Sorry if the tone is harsh, I’m a little embarrassed at giving the comment and then being shown I was wrong even through i looked in the docs for the correct answer) We even have a section in our docs for ordering in Vue that does not make reference to this here, implying it is not an opinion we hold, which i would have thought it to be not worth bring up in a code review. If each dev changes the order based on their opinion, it will artificially inflate the number of lines of code changed and add time to each review.
Additionally, if we have a preference for this, should it also extent to destructuring variables from an object?