@ohoral Left a few minor comments, otherwise LGTM! Approving....
nit: same as above
nit: white space before wrapper.vm.$refs.duoChat.$refs.prompt.$el.value
nit: jest structures the tests by describe name > test name so we can remove when
...
Nice name for the notification! Like it more than isChatFocused
@michaelangeloio AFAIK you're ok to merge? This MR has backend changes, so I shouldn't merge for you.
question: do we need to track numeric id or group/project
?
@adruid...
For the current task we need to track project_id
only in the instance_tracker
. Besides latest snowplow schema does not have this field and sending ...
@john-slaughter mind maintianerizing this and also commenting on !1409 (comment 2364471920) ?
Thanks @f_caplette! I agree with your feedback, I think we can refactor a bunch of this to be very nice and perhaps a bit generic, especially if we...
ahhh, should be clear now
YES VERY WEIRD...
yes I think we can manage a much nicer refactoring of this whole class now to differentiate between binary execution and docker execution, but uh.....
-
6dcaee69 · feat: add configuration to use docker for workflow
- ... and 17 more commits. Compare ae7221c3...6dcaee69
-
cea50eb5 · fix: add tests for suggestion clients
VSCode-wise, provided that we have hints, users are warned of the correct value types, so I'm less inclined to worry about stringy types or anythin...
Ahh sorry about that @ohoral!...