Skip to content
Snippets Groups Projects
Juhee Lee's avatar
approved merge request !1401 "chore: Handle chat focus state" at GitLab.org / editor-extensions / GitLab Language Server
Juhee Lee's avatar
commented on merge request !1401 "chore: Handle chat focus state" at GitLab.org / editor-extensions / GitLab Language Server

@ohoral Left a few minor comments, otherwise LGTM! Approving....

Juhee Lee's avatar
commented on merge request !1401 "chore: Handle chat focus state" at GitLab.org / editor-extensions / GitLab Language Server

nit: same as above

Juhee Lee's avatar
commented on merge request !1401 "chore: Handle chat focus state" at GitLab.org / editor-extensions / GitLab Language Server

nit: white space before wrapper.vm.$refs.duoChat.$refs.prompt.$el.value

Juhee Lee's avatar
commented on merge request !1401 "chore: Handle chat focus state" at GitLab.org / editor-extensions / GitLab Language Server

nit: jest structures the tests by describe name > test name so we can remove when...

Juhee Lee's avatar
commented on merge request !1401 "chore: Handle chat focus state" at GitLab.org / editor-extensions / GitLab Language Server

Nice name for the notification! Like it more than isChatFocused

Amy Qualls's avatar
commented on merge request !1404 "chore: Enable watch script to copy artifacts to JetBrains plugin" at GitLab.org / editor-extensions / GitLab Language Server

@michaelangeloio AFAIK you're ok to merge? This MR has backend changes, so I shouldn't merge for you.

Amy Qualls's avatar
approved merge request !1404 "chore: Enable watch script to copy artifacts to JetBrains plugin" at GitLab.org / editor-extensions / GitLab Language Server
Olena Horal-Koretska's avatar
commented on merge request !1397 "Draft: Resolve "Provide project_id while tracking events via Instance tracker."" at GitLab.org / editor-extensions / GitLab Language Server

question: do we need to track numeric id or group/project?

Olena Horal-Koretska's avatar
commented on merge request !1397 "Draft: Resolve "Provide project_id while tracking events via Instance tracker."" at GitLab.org / editor-extensions / GitLab Language Server

@adruid...

Olena Horal-Koretska's avatar
commented on merge request !1397 "Draft: Resolve "Provide project_id while tracking events via Instance tracker."" at GitLab.org / editor-extensions / GitLab Language Server

For the current task we need to track project_id only in the instance_tracker. Besides latest snowplow schema does not have this field and sending ...

Andrew Fontaine's avatar
commented on merge request !1409 "feat: add configuration to use docker for workflow" at GitLab.org / editor-extensions / GitLab Language Server

@john-slaughter mind maintianerizing this and also commenting on !1409 (comment 2364471920) ?

Andrew Fontaine's avatar
commented on merge request !1409 "feat: add configuration to use docker for workflow" at GitLab.org / editor-extensions / GitLab Language Server

Thanks @f_caplette! I agree with your feedback, I think we can refactor a bunch of this to be very nice and perhaps a bit generic, especially if we...

Andrew Fontaine's avatar
commented on merge request !1409 "feat: add configuration to use docker for workflow" at GitLab.org / editor-extensions / GitLab Language Server

ahhh, should be clear now :thumbsup:

Andrew Fontaine's avatar
commented on merge request !1409 "feat: add configuration to use docker for workflow" at GitLab.org / editor-extensions / GitLab Language Server

YES VERY WEIRD...

Andrew Fontaine's avatar
commented on merge request !1409 "feat: add configuration to use docker for workflow" at GitLab.org / editor-extensions / GitLab Language Server

yes I think we can manage a much nicer refactoring of this whole class now to differentiate between binary execution and docker execution, but uh.....

Andrew Fontaine's avatar
Allen Cook's avatar
  • cea50eb5 · fix: add tests for suggestion clients
Andrew Fontaine's avatar
commented on merge request !1409 "feat: add configuration to use docker for workflow" at GitLab.org / editor-extensions / GitLab Language Server

VSCode-wise, provided that we have hints, users are warned of the correct value types, so I'm less inclined to worry about stringy types or anythin...

Andrew Fontaine's avatar
commented on merge request !1395 "feat: show workflow end message when finished" at GitLab.org / editor-extensions / GitLab Language Server

Ahh sorry about that @ohoral!...