As part of #373 (closed) to work around lack of signed binaries we:
Defaulted to using the executable main-bundle.js which requires a NodeJS runtime.
Extended the language server settings to support customising the command path where that binary is unavailable.
Proposal
Download and package the binaries for all platform when building the plugin. This will result in a bigger plugin file size for now but will be tackled in a follow-up issue in the future.
Further details
This commit as a PoC implementation on how we can do this.
Kisha Mavryck Richardsonchanged title from Include gitlab-lsp binaries in release artifacts to [JetBrains] Include gitlab-lsp binaries in release artifacts
changed title from Include gitlab-lsp binaries in release artifacts to [JetBrains] Include gitlab-lsp binaries in release artifacts
Nothing to do but wait for #365 (closed) to be shipped here.
Erran Careychanged title from [JetBrains] Include gitlab-lsp binaries in release artifacts to [JetBrains] Support downloading standalone gitlab-lsp binaries
changed title from [JetBrains] Include gitlab-lsp binaries in release artifacts to [JetBrains] Support downloading standalone gitlab-lsp binaries
Erran Careychanged the descriptionCompare with previous version
Me @erran and @bohdanpk had a sync. We will include the binaries directly in the plugin as a first iteration to remove our dependency to node. We expect to be able to execute them after they have been downloaded using curl or via a GET request.
In a follow-up issue we will tackle reducing our bundle size by resolving the binaries at runtime and handling edge cases (download failing, download cancelled, checksum mismatch).
I'm picking this issue up for the rest of the milestone and maybe the start of 17.3. Assigned an updated weight of 2.
If you haven't already, let's craft a follow-up issue so that stays on our radar for prioritization & cc: myself, @erran + @bohdanpk within that issue.
Jean-Gabriel Doyonchanged title from [JetBrains] Support downloading standalone gitlab-lsp binaries to [JetBrains] Packaging gitlab-lsp binaries instead of using node
changed title from [JetBrains] Support downloading standalone gitlab-lsp binaries to [JetBrains] Packaging gitlab-lsp binaries instead of using node
Jean-Gabriel Doyonchanged title from [JetBrains] Packaging gitlab-lsp binaries instead of using node to [JetBrains] Package gitlab-lsp binaries instead of using node
changed title from [JetBrains] Packaging gitlab-lsp binaries instead of using node to [JetBrains] Package gitlab-lsp binaries instead of using node