Add documentation on things to check during review
[ Related to #616 and the discussion we had related to that]
To make it easier for new reviewers, we should look into writing basic documentation on what to check for during reviews based on the type of MR coming in. This need not be extensive and cover every possible scenario, but common things to check for during MRs. For example -
- If the MR involves a version change, ensure it builds on all OSs and QA passes
- If the MR changes a default value of a setting, ensure the backend team handling the related component is aware of it
- If the MR deprecates or removes a setting, ensure it is added to the deprecation list to be displayed during reconfigure and have a release post item label
We have an MR template at https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/.gitlab/merge_request_templates/General%20Change.md, so this documentation can be also converted to checklists that a reviewer can check off.