Switch default omnibus-mirror to the public one
I was trying to bundle install
omnibus-gitlab
and got this error message:
Retrying `git clone 'git@dev.gitlab.org:omnibus-mirror/ohai.git' "/Users/brodock/.rvm/gems/ruby-2.6.3/cache/bundler/git/ohai-6dec559a87dba2a860ea9e55d1de133febdb831d" --bare --no-hardlinks --quiet`
due to error (2/4): Bundler::Source::Git::GitCommandError Git error: command `git clone 'git@dev.gitlab.org:omnibus-mirror/ohai.git' "/Users/brodock/.rvm/gems/ruby-2.6.3/cache/bundler/git/ohai-6de
c559a87dba2a860ea9e55d1de133febdb831d" --bare --no-hardlinks --quiet` in directory /Users/brodock/Projetos/Gitlab/omnibus-gitlab has failed.The project you were looking for could not be found.
Looks like the way to install it locally without access to that group on dev is to use ALTERNATIVE_SOURCES=true
. I belive this is an anti-pattern, and it makes anyone contributing to GitLab having to do this extra step.
I propose here we do the opposite. Make the behavior of ALTERNATIVE_SOURCES=true
the default (clone from gitla.com
) and define on our deployment strategy and CI scripts to define its own env variable to download stuff from dev.
With this change we remove a barrier to external contributors while keeping our functionality and deployment/building workflow intact.
I started a discussion in slack here: https://gitlab.slack.com/archives/C1FCTU4BE/p1562602311043200
here is the important bits:
balu I don't think anyone other than Distribution have access on https://dev.gitlab.org/omnibus-mirror. I am not sure if others had before and was removed later.
balu marin dmountney Any idea?
marin
It was only available to Distribution team members because we didn't have nested groups. We also don't have sharing groups with groups so that makes it difficult. If you want to switch the default from private to public mirror that is fine as long as it does not affect our official package building. That takes precedence over all.