Use proper versioning scheme for builder images now that registry supports it
When we initially wrote our builder images, our registry supported only one image per project. So, we went with gitlab-omnibus-builder
as image name and <os_name>
as the image version, so that all our images could reside on same repo. Later, when we started versioning the images, we continued this pattern by appending -<image tag>
to the version part.
However, now the registry supports multiple images per project. So, essentially we could have sane versioning scheme that matches how docker tags are usually used. For example, change the builder images to the following structure
cookbooks/gitlab-omnibus-builder/ubuntu_14.04:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/ubuntu_16.04:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/ubuntu_18.04:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/debian_7:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/debian_8:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/debian_9:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/centos_6:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/centos_7:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/opensuse_42.3:${BUILDER_IMAGE_REVISION}
cookbooks/gitlab-omnibus-builder/sles_12sp2:${BUILDER_IMAGE_REVISION}