Skip to content

MRs require `~group::distribution` label, even when submitted by other teams

Initial report

MRs with the groupgeo label don't seem to be showing up on https://gitlab-org.gitlab.io/distribution/monitoring/mrs/. Would it make sense to display any ready to review MR in a Distribution-owned project regardless of team?

Summary

Some MRs don't appear on the monitoring dashboard because it checks for the ~"group::distribution" label. When other teams submit MRs to us, they often use their corresponding group's label - from the handbook:

If a contribution happens across groups, we leave it to the discretion of the engineering and product manager to change the group::xxx label to reflect which group worked on it.

As a workaround, we can consider enumerating Distribution-owned projects, and searching for any MRs in those projects with workflowready for review. This would help to ensure that MRs do not "slip through the cracks".

In fact, it like this was considered in this comment:

# We may want to instead, or also, go over all known distribution team owned projects

Edited by Mitchell Nielsen