Skip to content

The issue management panel should only work with GitLab projects

Problem

As an experiment, I tried to close via contributors.gitlab.com an issue in a project that is not part of GitLab:

freepascal.org/lazarus/lazarus#41804 (comment 2705151993)

The issue was not closed (the bot is not a member of this project), but it did add a comment.

Implementation plan

Contributors should only be able to manage issues with GitLab's own projects, not with any project hosted on gitlab.com.

Allowed groups (part of the URL after https://gitlab.com/):

  • gitlab-org
  • gitlab-com
  • gitlab-community
  • components

There are two pages where this check should be performed:

1. URL input page

When entering a link to an invalid project, an error message should be displayed.

The same code that currently displays an error when entering an invalid non-issue link can be reused (for example, a link to MR was entered here):

image

Perhaps a specific error message should be used, rather than the same thing.

2. Management panel issue page

If someone enters the URL manually, they may be taken to the issue management page. Therefore, the link should also be checked there, and an error should be displayed somewhere.

All this controls ("Label"/"Work"/"Close") also should be disabled:

image


/cc @gitlab-org/developer-relations/contributor-success

Edited by 🤖 GitLab Bot 🤖