Should Component development for Customer Portal happen in gitlab-ui?
The following discussion from !894 should be addressed:
-
@ClemMakesApps started a discussion: (+3 comments) Interesting. Is there a link to a discussion as to why we are creating a separate storybook? Why not use
gitlab-ui
and make it the central place for these components?
Why do we have a Storybook setup in the Customer Portal
- Storybook can serve as a scratchpad; UI development can happen without spinning the whole application up
- Spinning the actual application up requires a development environment which has a few manual steps, Zuora setup (which requires work from a Zuora admin), Linking with local gitlab instance, and setting up a reverse proxy
- Storybook is lighter to boot up
- Allows for focused MRs. Only submit relevant UI code, no need to juggle feature flags and data serialization, those can be submitted in another focused MR
- Velocity -
Collapse
has been a little over 5 weeks in review (yes it got delayed by the holiday season, but even still)
What do we gain from Component development in gitlab-ui
- We can leverage the skillset of gitlab-ui working group at the initial generation of components
- Components developed for the Customer Portal will be accessible in gitlab-core "for free"