### Problem When investing [this failed provision](https://customers.gitlab.com//admin/provision/39629), it was found that [the subscription](https://www.zuora.com/apps/Subscription.do?method=view&id=8a1282d486e9fbd9018705c72d2a044e) was already out of term. Zuora still considers the subscription version "active" though. This means our `ZuoraCallbackWorker` still tries to process the subscription due to the [`active_subscription?`](https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/a034215fb51579f24072cdaa45b6975cecf7c4bc/app/workers/zuora_callout/base_worker.rb#L61-63) check [here](https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/a034215fb51579f24072cdaa45b6975cecf7c4bc/app/workers/zuora_callback_worker.rb#L31). When attempting to check if the license is up to date, the `BuildLicenseFromSubscriptionService` will return `nil` if the [subscription is expired](https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/0be02174d35fbb423f97874feba0c39ecc7b4b18/app/services/build_license_from_subscription_service.rb#L18) which then causes the `LicenseNotificationService` to raise an error [here](https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/0be02174d35fbb423f97874feba0c39ecc7b4b18/app/services/license_notification_service.rb#L75). Another example from [SaaS subscription provision failure](https://gitlab.com/gitlab-org/customers-gitlab-com/-/issues/7226). `order.current_subscription` is `nil` because the Zuora subscription is already termed. This impact several places: - when `SubscriptionParamsGenerator` runs(called by update_plan_info_service) -- Not sure whether the update_plan_info_service will perform the update work as expected. But the update_plan_info_service logged an info `Subscription not found` and continued without throwing any error. - the provision won't be tracked because [`provision tracking` rely on `current_subscription`](https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/faf2bdc25e493ec37cb661823ad129e528b3f637/app/services/gitlab/namespaces/update_plan_info_service.rb#L261-273) --- For this reason, the provision did not have a chance to be marked as completed. ### Proposal Double check if subscriptions that are out of term still need to go through the callout logic and if not add a condition to prevent it. The callout logic could be: - license sending(for SM), - update plan info(for SaaS) :question: -- need further investigation - or, other related provision actions? -- need further investigation ### Result Prevent logic to be executed that is not needed (e.g. creating objects or even sending out emails).