Error in feature VCR cassette for upgrading a subscription
While working on https://gitlab.com/gitlab-org/customers-gitlab-com/-/issues/1281, I noticed that a VCR cassette included a 500 code for a pending migration. As this is not supposed to be there, let's fix it by rerecording that VCR cassette.
https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/ac07762fec2ee9bc0dff55dbd19f98e9979a1272/spec/fixtures/vcr_cassettes/upgrading_subscriptions/with_pajamas_upgrade_subscription_enabled/successfully_upgrades_plan.yml#L2211:
```
string: "ActiveRecord::PendingMigrationError at /api/v4/namespaces/70\n============================================================\n\n>
Migrations are pending. To resolve this issue, run:\n\n rails db:migrate
RAILS_ENV=development\n\n\n\nlib/gitlab/middleware/basic_health_check.rb,
line 25\n----------------------------------------------------\n\n``` ruby\n
\ 20 def initialize(app)\n 21 @app = app\n 22 end\n
\ 23 \n 24 def call(env)\n> 25 return @app.call(env)
unless env['PATH_INFO'] == HEALTH_PATH\n 26 \n 27 # We should
be using ActionDispatch::Request instead of\n 28 # Rack::Request
to be consistent with Rails, but due to a Rails\n 29 # bug described
in\n 30 # https://gitlab.com/gitlab-org/gitlab-foss/issues/58573#note_149799010\n```\n\nApp
backtrace\n-------------\n\n - lib/gitlab/middleware/basic_health_check.rb:25:in
`call'\n - lib/gitlab/middleware/handle_ip_spoof_attack_error.rb:25:in `call'\n
- lib/gitlab/middleware/request_context.rb:23:in `call'\n - config/initializers/fix_local_cache_middleware.rb:9:in
`call'\n - lib/gitlab/middleware/static.rb:11:in `call'\n - lib/gitlab/webpack/dev_server_middleware.rb:27:in
`perform_request'\n - lib/gitlab/metrics/requests_rack_middleware.rb:60:in
`call'\n - lib/gitlab/middleware/release_env.rb:12:in `call'\n\nFull backtrace\n--------------\n\n
- activerecord (6.0.3.1) lib/active_record/migration.rb:586:in `check_pending!'\n
- activerecord (6.0.3.1) lib/active_record/migration.rb:564:in `call'\n -
actionpack (6.0.3.1) lib/action_dispatch/middleware/callbacks.rb:27:in `block
in call'\n - activesupport (6.0.3.1) lib/active_support/callbacks.rb:101:in
`run_callbacks'\n - actionpack (6.0.3.1) lib/action_dispatch/middleware/callbacks.rb:26:in
`call'\n - actionpack (6.0.3.1) lib/action_dispatch/middleware/executor.rb:14:in
`call'\n - actionpack (6.0.3.1) lib/action_dispatch/middleware/actionable_exceptions.rb:17:in
`call'\n - better_errors (2.7.1) lib/better_errors/middleware.rb:84:in `protected_app_call'\n
- better_errors (2.7.1) lib/better_errors/middleware.rb:79:in `better_errors_call'\n
- better_errors (2.7.1) lib/better_errors/middleware.rb:57:in `call'\n - actionpack
(6.0.3.1) lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'\n
- actionpack (6.0.3.1) lib/action_dispatch/middleware/show_exceptions.rb:33:in
`call'\n - lib/gitlab/middleware/basic_health_check.rb:25:in `call'\n - railties
(6.0.3.1) lib/rails/rack/logger.rb:37:in `call_app'\n - railties (6.0.3.1)
lib/rails/rack/logger.rb:26:in `block in call'\n - activesupport (6.0.3.1)
lib/active_support/tagged_logging.rb:80:in `block in tagged'\n - activesupport
(6.0.3.1) lib/active_support/tagged_logging.rb:28:in `tagged'\n - activesupport
(6.0.3.1) lib/active_support/tagged_logging.rb:80:in `tagged'\n - railties
(6.0.3.1) lib/rails/rack/logger.rb:26:in `call'\n - sprockets-rails (3.2.1)
lib/sprockets/rails/quiet_assets.rb:13:in `call'\n - actionpack (6.0.3.1)
lib/action_dispatch/middleware/remote_ip.rb:81:in `call'\n - lib/gitlab/middleware/handle_ip_spoof_attack_error.rb:25:in
`call'\n - lib/gitlab/middleware/request_context.rb:23:in `call'\n - request_store
(1.5.0) lib/request_store/middleware.rb:19:in `call'\n - actionpack (6.0.3.1)
lib/action_dispatch/middleware/request_id.rb:27:in `call'\n - rack (2.0.9)
lib/rack/method_override.rb:22:in `call'\n - rack (2.0.9) lib/rack/runtime.rb:22:in
`call'\n - rack-timeout (0.5.2) lib/rack/timeout/core.rb:123:in `block in
call'\n - rack-timeout (0.5.2) lib/rack/timeout/support/timeout.rb:19:in `timeout'\n
- rack-timeout (0.5.2) lib/rack/timeout/core.rb:122:in `call'\n - config/initializers/fix_local_cache_middleware.rb:9:in
`call'\n - actionpack (6.0.3.1) lib/action_dispatch/middleware/executor.rb:14:in
`call'\n - actionpack (6.0.3.1) lib/action_dispatch/middleware/static.rb:126:in
`call'\n - lib/gitlab/middleware/static.rb:11:in `call'\n - lib/gitlab/webpack/dev_server_middleware.rb:27:in
`perform_request'\n - rack-proxy (0.6.0) lib/rack/proxy.rb:57:in `call'\n
- rack (2.0.9) lib/rack/sendfile.rb:111:in `call'\n - actionpack (6.0.3.1)
lib/action_dispatch/middleware/host_authorization.rb:82:in `call'\n - lib/gitlab/metrics/requests_rack_middleware.rb:60:in
`call'\n - sentry-raven (2.9.0) lib/raven/integrations/rack.rb:51:in `call'\n
- railties (6.0.3.1) lib/rails/engine.rb:527:in `call'\n - railties (6.0.3.1)
lib/rails/railtie.rb:190:in `method_missing'\n - lib/gitlab/middleware/release_env.rb:12:in
`call'\n - rack (2.0.9) lib/rack/urlmap.rb:68:in `block in call'\n - rack
(2.0.9) lib/rack/urlmap.rb:53:in `call'\n - gitlab-puma (4.3.3.gitlab.2) lib/puma/configuration.rb:228:in
`call'\n - gitlab-puma (4.3.3.gitlab.2) lib/puma/server.rb:691:in `handle_request'\n
- gitlab-puma (4.3.3.gitlab.2) lib/puma/server.rb:481:in `process_client'\n
- gitlab-puma (4.3.3.gitlab.2) lib/puma/server.rb:335:in `block in run'\n
- gitlab-puma (4.3.3.gitlab.2) lib/puma/thread_pool.rb:138:in `block in spawn_thread'\n\n"
```
issue