Investigate multiyear_subscription? check
The following discussion from !13549 should be addressed: - [ ] @rcobb started a [discussion](https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/13549#note_2772381668): > **thought:** Not related to your changes but while investigating `subscription.multiyear_subscription?` I noticed we don't check `current_term_period_type`. According to [Zuora docs](https://knowledgecenter.zuora.com/Zuora_Platform/Integration/API/G_SOAP_API/E1_SOAP_API_Object_Reference/Subscription), this field controls the units for `current_term`. > > In staging, I'm seeing: > > ``` > [ stg ] stg> Zuora::Local::Subscription.distinct.pluck(:current_term_period_type) > Zuora::Local::Subscription Pluck (3.5ms) SELECT DISTINCT "zuora_subscriptions"."current_term_period_type" FROM "zuora_subscriptions" > => ["Month", "Year"] > ``` > > I think we might need to update `Subscription#multiyear_subscription?` to account for this 🤔 - [ ] @fjedelhauser started a [discussion](https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/13549#note_2771668088): > @minahilnichols Everything looks good to me the only question I had was around the requirements in the issue not quite matching up with the validation check. In the issue the requirement says `subscription term = 12 months (not a multi-year / ramp)` however the implementation checks `current_term > 12`. Is that expected?
issue