Stop testing internals in requests specs
Problem
Request specs are for testing the application from the perspective of a machine client. They begin with an HTTP request and end with the HTTP response, so they’re faster than feature specs, but do not examine your app’s UI or JavaScript.
Request specs provide a high-level alternative to controller specs. In fact, as of RSpec 3.5, both the Rails and RSpec teams discourage directly testing controllers in favor of functional tests like request specs.
When writing them, try to answer the question, "For a given HTTP request (verb + path + parameters), what HTTP response should the application return?"
Proposal
Examine all our request specs and remove any assets on internal implementation.
Result
Faster and more stable tests.
How will we measure success?
We should expect the same or slightly less code coverage.