Follow-up from "Check DuoPro trial eligibility"
Refer to this comment https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/9454#note_1801392382
it comes from GitLab itself and is now handled here - it does not include
parent_id
.
We might want to add parent_id
here.
Needs double check before make decision.
The following discussion from !9454 should be addressed:
-
@vij started a discussion: (+5 comments) question: using
parent_id
to establish if the namespace is the root one or not makes sense if we've retrieved the namespace from the GL API, but looking at theCreateTrialService#load_namespace
method, it seems like we sometimes getnamespace
from params - is it possible that we might get a sub-group passed in without theparent_id
, via params?🤔
as a non-blocking sidenote, I wonder if we should instead change the GL namespace entity to return a
root_group
(or similar) boolean, so we can keep that logic within GL itself rather than trying to establish the same via param checking in a completely different application?🤔