Users with custom guest role are not included in seats calculation when purchasing Premium if namespace is currently on Ultimate trial
Bug
Summary
Users with custom guest role are not included in the seat calculation when purchasing Premium when namespace is currently on an Ultimate trial. This results in instant seat overage and is a surprise to the customer who didn't have visibility of those seats during purchase.
Relevant slack thread.
Steps to reproduce
- Start Ultimate trial on group namespace
- Add user to namespace with custom role, based on guest, with a permission added to read
- Go to group billing page to purchase Premium plan
- Check that the seat calculation excludes user with custom guest-based role
What is the current bug behavior?
- Purchase flow seat calculation excludes users that are billable
- The number of purchased seats do not cover the billable users on the namespace
- After purchase, the namespace instantly has a seat overage
What is the expected correct behavior?
(What you should see instead)