Reduce the number of specs using VCR
Proposal
Proposal based on this comment from @tyleramos.
New proposed guideline: VCR should be reserved for feature-level testing. Unit specs should utilize stubbing as much as possible to keep them lightweight. Also, when VCR is used in feature specs, we should minimize the number of specs as much as possible by testing the happy or mission critical paths.
This issue will track the following efforts:
- Identify existing VCR specs that might be testing too much under VCR and refactor/remove them
- Add documentation to
doc/testing/test.md
to state this guideline and broadcast it Fulfillment engineers, especially for maintainers to watch out for this when reviewing MRs.
Sub-issues
- [Fulfillment Platform] Reduce the number of spe... (#7415 - closed)
- [Utilization] Reduce the number of specs using VCR (&11380)
- [Billing and Subscription Management] Reduce th... (#7417 - closed)
- [Provision] Reduce the number of specs using VCR (#7419)
- [Purchase] Reduce the number of specs using VCR (#7420)
Result
Less VCR friction, faster execution of our test suite.
Edited by Chase Southard