Order with `end_date: nil` should be active order
Problem
Triggered from a discussion from https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/7511#note_1416425834.
ATM if order.end_date: nil
, this order is not considered active
.
scope :active, ->(date = Date.current) { where('end_date >= ?', date) }
scope :active_within_grace_period, (lambda do
where("end_date + INTERVAL '? days' >= ?", EXPIRATION_GRACE_PERIOD.to_i / 1.day, Date.current)
end)
Proposal
We want to investigate to answer below questions:
- Do we have valid orders where
end_date: nil
? - Do we need to include such
end_date: nil
orders to beactive
orders?