Upgrade countries gem to 4.0.1
Problem
Currently GitLab.org using countries gem with version 4.0.1
, where as CDot uses 2.1.2
. It may be better if we sync up the version of the gem, since there is customer data related to billing address transfer between the two.
Resources
- Prior discussion on upgrade: gitlab#404750 (comment 1379558442)
- Previous findings for the upgrade: &10141 (comment 1381809033)
this gem does not block the Ruby 3 upgrade and upgrading it is a complicated task as we use it in many places across the application:
- https://gitlab.com/gitlab-org/customers-gitlab-com/blob/main/lib/world.rb#L3
- https://gitlab.com/gitlab-org/customers-gitlab-com/blob/main/app/services/compliance_check_service.rb#L55
- https://gitlab.com/gitlab-org/customers-gitlab-com/blob/main/app/models/instance_review.rb#L4
- https://gitlab.com/gitlab-org/customers-gitlab-com/blob/main/app/services/gitlab/base_trial_service.rb#L27
- https://gitlab.com/gitlab-org/customers-gitlab-com/blob/main/app/services/find_or_create_customer_service.rb#L128
And so on.
- GitLab.org MR for upgrade: gitlab!106533 (merged)
Proposal
Upgrade countries
gem in CDot to 4.0.1
Result
Consistency on country gem versions between CDot and GitLab.org
Edited by Bishwa Hang Rai