[Feature flag] Enable block_seat_overage_notification
Summary
This issue is to rollout and cleanup a feature to prevent enqueuing SendSeatOverageNotificationJob
for certain namespaces in CustomersDot production, that is currently behind the block_seat_overage_notification
feature flag.
Owners
- Team: ~"group::billing and subscription management"
- Most appropriate Slack channel to reach out to:
#g_billing_and_subscription_management
- Best individual to reach out to: @jhyson @tyleramos
- PM: @tgolubeva
Stakeholders
The Rollout Plan
- This feature was rolled out immediately in production to mitigate the issue that was bloating our Sidekiq queues.
Expectations
What are we expecting to happen?
When enabled, this feature will prevent the SendSeatOverageNotificationJob
from being enqueued for specific GitLab namespace ids (currently just 10782951
). See https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/5582 for more info.
What might happen if this goes wrong?
The feature flag should make it easier to toggle this blocking logic. If it doesn't work, it's possible that the SendSeatOverageNotificationJob
doesn't get blocked properly for the specified namespace.
What can we monitor to detect problems with this?
We can monitor problems in Sentry or in Sidekiq.
Rollout Steps
Rollout on non-production environments
-
Ensure that the feature MRs have been deployed to non-production environments, i.e. customers-staging
. -
Consider announcing that the flag will be enabled to potentially impacted groups, e.g. #s_fulfillment_engineering
-
Enable the feature globally on non-production environments by applying the appropriate environment, e.g. customers-staging
andcustomers-development
. -
Notify the Software Engineers in Test (SETs) for Fulfillment via Slack and in a comment in this issue when enabling a feature flag in customers-staging
as it can impact the QA pipeline. -
Verify that the feature works as expected. Posting the QA result in this issue is preferable.
Preparation before production rollout
-
Ensure that the feature MRs have been deployed to production -
Check if the feature flag change needs to be accompanied with a change management issue. Cross link the issue here if it does. -
Ensure any documentation has been updated -
Announce on the feature issue an estimated time this will be enabled on production if applicable
Global rollout on CustomersDot production
-
Confirm the feature flag is enabled on staging
without incident -
Roll out the feature to targeted testing users first (if applicable) -
If applicable, incrementally roll out the feature. -
Verify the change has the desired outcome with the limited rollout before enabling the feature globally on production. -
Enable the feature globally on production environment -
Announce on the feature issue that the feature has been globally enabled. -
Wait for at least one day for the verification term.
Release the feature
After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.
-
Ensure gitlab#358080 (closed) has been resolved before removing the feature flagged code. -
Create a merge request to remove block_seat_overage_notification
feature flag-
Remove all references to the feature flag from the codebase
-
-
Ensure that the cleanup MR has been deployed to both staging and production -
Disable the feature flag via the CustomersDot dashboard -
Ensure production environment is still working as expected -
Remove the Unleash feature flag from the CustomersDot dashboard -
Close this rollout issue.
Rollback Steps
-
This feature can be disabled by performing the following actions: -
Disable the Unleash flag on the feature flag page
-