Remove self service condition from activation code logic
Background
The original activation code logic had a couple of checks in place in order for a code to be generated:
- Validate the Super Sonics fields (i.e. auto-renewal, operational metrics) were populated OR
- Validate the purchase was made through self service
In reviewing this logic, it was determined that there was no need for the SS field dependency (detailed reasoning outlined here). As a result, this was removed as part of this issue: #4688 (closed)
Problem
Since this update, we have identified that the activation code logic still includes the check that a purchase was completed through a self-service path. With the SS logic removed, this is now preventing activation code creation for all sales assisted Self-Managed purchases.
Note: self-service purchases are still working as expected
Reported Examples
- https://gitlab.zendesk.com/agent/tickets/321798
- https://gitlab.slack.com/archives/C018C623KBJ/p1661947151593559?thread_ts=1661268847.706399&cid=C018C623KBJ
Proposal
Remove the self_service?
check altogether from the activation code logic.
Result
Cloud activation codes will be created for all Self-Managed subscriptions who do not have TurnOnCloudLicensing
= No
, regardless of purchase method.