Retire LicenseData class
The following discussion from !4512 should be addressed:
-
@aish.sub started a discussion: (+3 comments) Moved
LicenseData
class underapp/models
and renamed the class toLicenseKey
.I initially thought of using the
License
model and getting rid of this class entirely, however there are a lot of additional validations in the model class that may not be appropriate for this case. -
@lulalala suggested: I feel over time many of
LicenseData
's responsibilities were stripped away:- There is no longer the need to create a subset of the license hash. The full hash would work just as well.
- It was a common interface between remote API data and decrypted data, but now only decrypted data is available
Therefore its only purpose is to validate that some hash keys exists.
WDYT if we tackle it instead (in another MR) by merging it with
FindFromLicenseKeyService
, which should really be renamed asLiceseKeyReader
orLicenseKeyDecrypter
?
Edited by Aishwarya Subramanian