Start replacing constants and methods with new Finder class references
Proposal
Once the Zuora Product Catalog Finder class is added in #3487, we can start the process of replacing some of the APP_CONFIG
references in Plan
model constants and methods. For example, GITLAB_EE_STARTER_1_YEAR_PLAN
is defined here using APP_CONFIG.zuora.gitlab_ee_starter_1_year_plan
. The Finder class should enable us to query the Zuora product catalog for this appropriate ID.
Let's introduce a new feature flag (e.g. product_catalog_finder
) for the new logic.
We should determine which constants actually need to be replaced in the Plan model. I've noticed there are a number of constants that are created only to add them to a plan tier list (SaaS vs SM). I suspect we can trim down the number of constants needed. Some plan constants could be removed in favor of class methods that use the finder class.
Result
Let's start small and work iteratively through updating all the constants/methods. The result of this issue should be the introduction of the feature flag and updating a small set of constants. Create more issues as needed for additional changes.