Manually created licenses with typo causing Seat Link failures
Problem
I noticed when verifying the changes from https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3563 that some errors have been occurring in the SeatLinkCreateService when the license received in the request contains a zuora_subscription_name
with a typo. Specifically, in the cases I've seen (see Sentry links below), the zuora_subscription_name
contains and extra whitespace character at the end of the string which causes Zuora::Subscription
not to be found when queried. In both cases, the licenses were created manually in LicenseDot.
Sentry Issues:
- https://sentry.gitlab.net/gitlab/customersgitlabcom/issues/2735681/events/f0637a1b406b436eb2c8568cb3dc16ee/
- https://sentry.gitlab.net/gitlab/customersgitlabcom/issues/2735681/events/484f4cd8ace848558c4bd802b93aee4e/
Proposal
A simple solution could be to trim the trailing whitespace characters when processing the seat link request.