Investigate and log empty zuora_subscription_name fallback usage in CloudConnector::AccessService

During review of !14502, a question was raised about the fallback logic in CloudConnector::AccessService that handles cases where license.zuora_subscription_name is empty.

Context

  • Cloud licensing was released in June 2021, which should align with when all cloud licenses received subscription names
  • Legacy licenses are already prevented from accessing tokens via the license.valid_cloud_license? check
  • The fallback to use license.subscription_name may no longer be necessary

Proposed Action

Add logging to track when license.zuora_subscription_name is empty for 30 days to determine:

  1. If this scenario actually occurs in production
  2. Whether the fallback logic can be safely removed

After 30 days of monitoring, review the logs to decide on the path forward:

  • Full removal: If no occurrences are logged, remove the fallback from:
    • CloudConnector::AccessService
    • Api::V1::SeatLinksController
    • CreateSeatLinkService
  • Continue supporting: If occurrences are found, keep the fallback in place

Related

  • MR: !14502
  • Work Item: #15566