Trial monthly resets for usage billing explciteness
The following discussion from !14425 should be addressed:
-
@vburton started a discussion: (+6 comments)
Suggestion (out of scope for this MR): Since these trial credits also won't be eligible for monthly resets, we are going to have an issue with the wallet balance never getting cleared / reset when the credits expire. Today with the way the wallet balance is designed, expired credits still get included in the balance, and we rely on the
MonthlyCreditResetJobto reset the balance for non-trial wallets. While expired credits are ignored by consumption, theConsumer::Resolverrelies on wallet balances to determine if access should be granted.This is very similar to what we encountered with bonus trial credits. We needed to create the
Billing::RecalculateBonusTrialBalancesCronJobto clear expired credits on a daily basis as a workaround (issue). The long term solution to fix this will be handled by [Proposal]Time-aware credits to fix rollover an... (#15087), but I'm not sure that would be ready before February 10thI believe an issue will need to be created to handle this for consumer trial credits as well. The team could possibly look into extending
Billing::RecalculateBonusTrialBalancesCronJob+Billing::RecalculateBonusTrialBalanceJobto include expired consumer trial credits too@qzhaogitlab could you also please review the above and let us know your thoughts?
🙏