Clarify params used for gitlab_support_url helper method
The following discussion from !1169 should be addressed:
-
@oswaldo started a discussion: (+1 comment) I'm not sure if I follow this number, should that be extracted to some constant, or YAML config?
Problem
Currently, the gitlab_support_url
helper method accepts an optional param for ticket_form_id
. This is used throughout the views with param values like 360000071293
and 334447
. It's not clear what these values mean.
Proposal
Instead of using these numbers directly when calling the helper method, it would be preferable to set these as constants or set them in application.yml. Referencing them in one place will make it easier to update in the future and make it clearer when seeing the reference in code. For example, this gitlab_support_url(LICENSING_AND_RENEWAL_PROBLEMS)
is clearer than gitlab_support_url(360000071293)
.