Skip to content

Code Review 17.10 Planning : February

Release planning for the Code Review Group

Overview - 17.10 Release Board

Backend

Planning distribution

Priorities

  1. Security - https://gitlab.com/gitlab-org/gitlab/-/issues/514532
  2. infradev
    1. https://gitlab.com/groups/gitlab-org/-/epics/16385 - short runway, high complexity -> investigate
    2. &13435 - long runway, low complexity -> no action for now
  3. corrective action &13512
    1. https://gitlab.com/gitlab-org/gitlab/-/issues/516870 - also infradev
    2. TODO: Review other actions to stack rank
  4. AI
    1. Duo Code Review external Experiment - &14825 (closed) - should be done in 17.9 🤞
    2. Duo Code Review feedback - reserve some capacity to react quickly. w3 + potential borrow.
    3. Duo Code Review Beta - &16298 (closed) - docs + enable S-M + rollout
    4. GA other features - &10347 or &10769 - preference towards Code Review Summary. Unit primitive work + EE.
  5. Cells 1.0 - &12795 - @kerrizor will continue this for the moment.
  6. Auto-merge bugs - &16143 - possibly just FF rollout, see #13249 (comment 2339313913)
  7. Keep-around ref research/refinement? Is the WG back to focusing on attribution? We should focus on improving our docs: gitlab#515197 (closed) (which is also a corrective action).
  8. Feature flag cleanup - gitlab#502721 (closed) - document process change to keep this in check
  9. Stacked Diffs for the CLI - &12025
  10. Rebase & merge in 1 click - &16803 - maybe a pairing effort? Pick up from research work done by Source Code.
  11. Rapid Diffs - &13764 (closed) - pause in favor of infradev?

Frontend

Planning distribution

Priorities

Issues scheduled for 17.10

Unassigned issues backend / frontend (should be empty by the end of planning) 
display: table
fields: epic, title, assignee, weight, labels("type::*", "backend", "frontend")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend", "cli", "frontend") and label != "type::ignore"
  and milestone = "17.10" and opened = true
  and assignee = none
Scheduled issues (sort by epic) backend 
display: table
fields: epic, title, assignee, weight, labels("type::*", "Deliverable", "Stretch")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("backend", "cli") and label != "type::ignore"
  and milestone = "17.10" and opened = true
Scheduled issues (sort by epic) frontend 
display: table
fields: epic, title, assignee, weight, labels("type::*")
query:
  group = "gitlab-org" and label = "group::code review"
  and label in ("frontend") and label != "type::ignore"
  and milestone = "17.10" and opened = true

Slippage from 17.9

Open backend issues from 17.9 
display: table
fields: health, assignee, weight, labels("backend-weight::*", "workflow::*"), labels( "Deliverable", "Stretch"), title
query:
  group = "gitlab-org" and opened = true and milestone = "17.9"
  and assignee in ("garyh", "kinsingh", "marc_shaw", "patrickbajao", "dskim_gitlab")
Open frontend issues from 17.9 
display: table
fields: health, assignee, weight, labels("frontend-weight::*", "workflow::*"), labels( "Deliverable", "Stretch"), title
query:
  group = "gitlab-org" and opened = true and milestone = "17.9"
  and assignee in ("iamphill", "slashmanov", "thomasrandolph")

Quick wins

Weight 1 backend issues 
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "backend" and weight = 1 and opened = true
Weight 1 frontend issues 
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "frontend" and weight = 1 and opened = true
quick win issues 
display: table
fields: assignee, weight, title, milestone, updatedAt
query: group = "gitlab-org" and label = "group::code review" and label = "quick win"  and opened = true

Stable counterparts

Staff+ engineers

All engineers are welcome to contribute to the planning process! Staff+ engineers are expected to contribute, see references below, and are therefore tagged here explicitly to ensure visiblity as soon as the issue is created.

Handbook references:

  • Staff+ archetype - Tech Lead
    • "A Staff Engineer partners with the Engineering Manager and the Product Manager for milestone planning"
  • Staff+ archetype - Right hand
    • "Staff+ Engineers are supposed to broaden the perspectives of their managers. Decision-makers often need the additional context and perspective to make well-informed decisions about investments in the product architecture, understanding expected ROI"
  • Development Staff career framework
    • "Works with the Engineering Manager to assign work to the team"

Missing labels / weights

%17.10 issues without a backend / frontend / cli label (list should be empty):

---
display: table
fields: assignee, weight, title
---
group = "gitlab-org" and label in ("group::code review") and milestone = "17.10" and label != "type::ignore" and opened = true and label != "frontend" and label != "backend"  and label != "cli"

%17.10 issues without a weight (list should be empty):

---
display: table
fields: assignee, labels("backend", "frontend"), weight, labels("backend-weight::*", "frontend-weight::*"), title
---
group = "gitlab-org" and label in ("group::code review") and milestone = "17.10" and label != "type::ignore" and opened = true and weight = None

(improve this template?)

Edited by François Rosé