Completed performance issues issues for the 13.12 RP
Please review the issues below, taking the following steps:
- Determine if the issue has been completed,
- Add it to the corresponding Release Post MR if it has (markdown is provided for copy & paste),
- Check off the task item to show it's been reviewed.
Frontend Source Code
Please review these issues @andr3:
- [Performance degradation on snippet view](https://gitlab.com/gitlab-org/gitlab/-/issues/327782)
Backend Source Code
Please review these issues @sean_carroll:
-
Add metrics for "API JSON caching for tags endpoint" - closed -
Improve performance of show action for Projects::CommitController under load into S3 tier - workflowverification -
Performance: Improve performance of show.json action (rendered) for Projects::BlobController under load into the s3 tier - workflowin review -
RemoveUnreferencedLfsObjectsWorker fails every time with a statement timeout - workflowin review -
Make MergeService idempotent - closed
- [Add metrics for "API JSON caching for tags endpoint"](https://gitlab.com/gitlab-org/gitlab/-/issues/324383)
- [Improve performance of show action for Projects::CommitController under load into S3 tier](https://gitlab.com/gitlab-org/gitlab/-/issues/322559)
- [Performance: Improve performance of show.json action (rendered) for Projects::BlobController under load into the s3 tier](https://gitlab.com/gitlab-org/gitlab/-/issues/271242)
- [RemoveUnreferencedLfsObjectsWorker fails every time with a statement timeout](https://gitlab.com/gitlab-org/gitlab/-/issues/199261)
- [Make MergeService idempotent](https://gitlab.com/gitlab-org/gitlab/-/issues/32737)
Frontend Code Review
Please review these issues @andr3:
-
Halt unnecessary polling requests when the page visibility is hidden - closed -
Proposal: Speed up MR Diffs loading and rendering with data caching - workflowin review
- [Halt unnecessary polling requests when the page visibility is hidden](https://gitlab.com/gitlab-org/gitlab/-/issues/326772)
- [Proposal: Speed up MR Diffs loading and rendering with data caching](https://gitlab.com/gitlab-org/gitlab/-/issues/322202)
Backend Code Review
Please review these issues @mnohr:
-
Defining large MR for performance testing - closed -
DELETE /api/projects/:id/merge_requests/:merge_request_iid executes more than 100 SQL queries - workflowverification -
Projects::MergeRequests::CreationsController#create P90 is above 500ms - closed -
Improve performance of Merge Request List API under load to meet target - workflowverification -
UpdateMergeRequestsWorker can be expensive and exceed it's execution SLO thresholds - workflowin review -
Controller Projects::MergeRequestsController#update executes more than 100 SQL queries - workflowverification
- [Defining large MR for performance testing](https://gitlab.com/gitlab-org/gitlab/-/issues/327128)
- [DELETE /api/projects/:id/merge_requests/:merge_request_iid executes more than 100 SQL queries](https://gitlab.com/gitlab-org/gitlab/-/issues/325689)
- [Projects::MergeRequests::CreationsController#create P90 is above 500ms](https://gitlab.com/gitlab-org/gitlab/-/issues/325672)
- [Improve performance of Merge Request List API under load to meet target](https://gitlab.com/gitlab-org/gitlab/-/issues/250356)
- [UpdateMergeRequestsWorker can be expensive and exceed it's execution SLO thresholds](https://gitlab.com/gitlab-org/gitlab/-/issues/218410)
- [Controller Projects::MergeRequestsController#update executes more than 100 SQL queries](https://gitlab.com/gitlab-org/gitlab/-/issues/20827)
Backend Ecosystem
Please review these issues @arturoherrero :
-
Projects::Settings::IntegrationsController#show executes more than 100 SQL queries - closed -
PUT /api/projects/:id/merge_requests/:noteable_id/notes/:note_id executes more than 100 SQL queries - closed -
Missing foreign key constraint on web_hooks.group_id - closed
- [Projects::Settings::IntegrationsController#show executes more than 100 SQL queries](https://gitlab.com/gitlab-org/gitlab/-/issues/326209)
- [PUT /api/projects/:id/merge_requests/:noteable_id/notes/:note_id executes more than 100 SQL queries](https://gitlab.com/gitlab-org/gitlab/-/issues/325690)
- [Missing foreign key constraint on web_hooks.group_id](https://gitlab.com/gitlab-org/gitlab/-/issues/202423)
Be sure to check the issue list closer to the end of the milestone for any changes. You may also want to look through Merge Requests for any fixes that didn't have an issue.
Edited by Arturo Herrero