Skip to content

Better define merge request widgets, merge checks, merge widget and approvals

Problem to Solve

We have some competing terminology and generally overlapping concepts related to:

  • Merge Widget
  • Merge request widgets
  • Merge checks
  • Merge request approvals

Examples:

  1. Screen_Shot_2021-03-24_at_12.05.08_PM

  2. Initial research proposal for Merge request widget research originally had to clarify which widget was meant.

  3. Merge checks and merge approval being conflated in - &4366 (comment 536075481)

Proposal

We should define what each of these things is, with some kind of example and try to eliminate any of the duplicative terminology. We also need to document this, and I'd propose the shared Code Review handbook as a good place to do this.

Ideas for discussion in threads below.