Skip to content
Snippets Groups Projects

Improve Production Install

Added curl to pre-chef Ubuntu setup as it does not come with certain Ubuntu versions, including the default virtualbox used for development, precise64.

The rest are minor improvements which I think make the instructions slightly better.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sorry for changing everything on the new commit. I though it over and I believe that the current version makes it much clearer how to install:

    • tell users to edit the .json before running the install, since it is most likely what everyone will do
    • auto recognize distro via lsb_release
    • suggest that users remove the .json after usage since it contains passwords
  • Thanks for contributing Ciro, I'll leave the assesment of this MR up to @marin

  • 48 EOF
    17 49 ```
    18 50
    19 ```bash
    20 ## Centos
    21 yum groupinstall -y "Development Tools"
    22 ```
    51 You only need to keep parameters which need to differ from their default values.
    52 For example, if you are using `mysql`, there is no need to keep the `postgresql` configuration.
    23 53
    24 Following steps are the same for both OS:
    54 Run:
    25 55
    26 56 ```bash
    57 distro="$(lsb_release -i | sed -r 's/.*:\t(.*)/\1/')"
    58 case "$distro" in
    • I would like to see this in separate bash block because right now it is unclear what to do with this. Can you separate the distro check with something like: "First we install dependencies based on the OS used", then add distro and case to the bash block. After that you will have a line that says something like: "Next steps are" and the second bash block will start with cd /tmp command.

    • Is the new commit what you meant?

      I don't quite understand what you meant by "unclear what to do with this" before the new commit. It seems clear that end users should just copy paste the script to finish the install, or what you meant is that it is harder for people to understand the script?

      I believe that having to do a single copy paste to install is more user friendly than having to do several: users don't even need to think to install, just one copy paste and done. It is also simpler for end users to save the script so they can use it many times (we could even serve the script separately one day so they can curl install it).

      If the problem is making the script more understandable, a compromise would be to just add one comment on the distro detection.

      But hey, I'm new here and maybe I am missing something. Whichever you guys think is best I'll agree to =)

  • Please register or sign in to reply
    Loading