Skip to content

No webhook notifications for events on the new code path

Context

Found in gitlab#359852 (closed).

Problem

We have identified that the registry is not emitting webhook notifications for events when those happen on the new code path.

This only happens when:

  • Using the metadata database;
  • The migration mode is enabled;
  • Filesystem metadata mirroring is disabled;
  • The repository is on the new code path.

This happens because the webhook notifications listener wraps filesystem metadata operations, so when running with filesystem metadata mirroring, none of the wrapped operations is executed. Therefore the outer notification wrapper isn't executed either and no notifications are sent.

Solution

After fixing notifications for the most urgently needed events in #682 (closed), we should now refactor the notification mechanism so that it plays well with the new code path and re-enabled all event notifications.