Skip to content
  • Josh Hawn's avatar
    Improve context package · 731e0b00
    Josh Hawn authored
    You shouldn't have to import both:
    
      github.com/docker/distribution/context
      golang.org/x/net/context
    
    just to use the distribution tools and implement the distribution interfaces.
    
    By pulling the Context interface from golang.org/x/net/context into the
    context package within the distribution project, you no longer have to import
    both packages.
    
    Note: You do not have to change anything anywhere else yet! All current uses
    of both packages together will still work correctly because the Context
    interface from either package is identical.
    
    I've also made some other minor changes:
    
    - Added a RemoteIP function. It's like RemoteAddr but discards the port suffix
    - Added `.String()` to the response duration context value so that JSON log
      formatting shows human-parseable duration and not just number of nano-seconds
    - Added WithMapContext(...) to the context package. This is a useful function
      so I pulled it out of the main.go in cmd/registry so that it can be used
      elsewhere.
    
    Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
    731e0b00
Loading