Draft: Removes ScannerVersion and FileCheckSum from Report JSON schema
What does this MR do and why?
THIS IS A WIP MR - TBD whether this update is indeed needed in the XRay
repo.
We are removing scannerVersion
and checksum
fields from the XRay Report JSON schema since it's not currently being used anywhere for verification and we currently don't have a concrete implementation strategy in place for the checksum
logic. Please see here for more details.
Merge request reports
Activity
assigned to @squadri
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @acook.gitlab
(UTC-4)
@mikolaj_wawrzyniak
(UTC+0)
Generated by
DangerEdited by ****added 1 commit
- 5ec84bae - Removes ScannerVersion and FileCheckSum from Report JSON schema
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@squadri
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added 1 commit
- 73305a17 - Updates tests to reflect fileName rename and removal of fields
added typemaintenance label
added 1 commit
- c3fdd03a - Removes redundant FileChecksum function and test
added 1 commit
- eb9f7668 - Removes scannerVersion and checksum refs and updates test