Improve handling of core services errors
Recently in trying to track down failure of the functional tests (job 1590736145) it was found that the operator was reporting back that the core services were not operational and the tests timed out.
PostgreSQL, Redis and Gitaly are considered the core services and are being tested in ifCoreServicesReady()
. ifCoreServicesReady()
should be returning an error
instead of a boolean
so that the service that is not ready can be reported back to the calling routine and logged appropriately.
Edited by Gerard Hickey