The following discussions from !3433 should be addressed: - [ ] @hacks4oats started a [discussion](https://gitlab.com/gitlab-org/cli/-/merge_requests/3433#note_3481892577): > **style**: The Go convention is to uppercase all initialisms like `URL`. I think `RSA` qualifies in this case. > > ```suggestion:-0+0 > func generateRSAKey(filename string, bits int) error { > ``` - [ ] @hacks4oats started a [discussion](https://gitlab.com/gitlab-org/cli/-/merge_requests/3433#note_3481892591): > ```suggestion:-0+0 > func generateED25519Key(filename string) error { > ``` - [ ] @hacks4oats started a [discussion](https://gitlab.com/gitlab-org/cli/-/merge_requests/3433#note_3481892594): > ```suggestion:-0+0 > func generateECDSAKey(filename string, curve elliptic.Curve) error { > ``` - [ ] @hacks4oats started a [discussion](https://gitlab.com/gitlab-org/cli/-/merge_requests/3433#note_3481892595): > ```suggestion:-0+0 > func generateECDSAKeyManual(filename string, curve elliptic.Curve) error { > ```