fix(ci get): do not require branch if pipelineID is given

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.

Description

• fix(ci get): do not require branch if pipelineID is given

• Do not try to process branch when pipelineID is known
• Prevents such ci get from failures in detached HEAD state

Fixes #7741 (closed)

Related Issues

Resolves #[issue_number]

How has this been tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation
• Chore (Related to CI or Packaging to platforms)
• Test gap

Thanks for your contribution to GitLab @abitrolly!

• If you need help, page a coach by clicking here or come say hi on Discord.
• When you're ready, request a review by clicking here.
• We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
• To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".

This message was generated automatically. Improve it or delete it.

added Community contribution workflowin dev labels

assigned to @abitrolly

changed the description

This merge request will be counted as part of the running Hackathon!

Find yourself in the Hackathon Leaderboard or check out the Hackathon page for more information!

This message was generated automatically. Improve it or delete it.

added Hackathon label

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Reviewer	Maintainer
@ck3g (UTC+1)	@viktomas (UTC+1)

Generated by Danger

added linked-issue label

mentioned in issue #7741 (closed)

@gitlab-bot ready

added workflowready for review label and removed workflowin dev label

Hi Coach @dmishunov, this Community contribution is ready for review or needs your coaching.

• Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
• If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
• Please ensure the group's Product Manager has validated the linked issue.

This message was generated automatically. Improve it or delete it.

requested review from @dmishunov

mentioned in issue gitlab-org/quality/triage-reports#22003 (closed)

@dmakovey, could you please help reviewing this Community contribution? I don't have sufficient expertise in this area.

requested review from @dmakovey and removed review request for @dmishunov

added 1 commit

• 3c575e6a - fix: remove debug output

Compare with previous version

resolved all threads

added devopscd label

Thank you @abitrolly , visually changes look OK to me. I'll take a look at functional impact a bit later to confirm results of visual inspection.

added devopscreate groupcode review sectiondev typefeature labels and removed devopscd label

added 22 commits

• 3c575e6a...a59d18bb - 20 commits from branch gitlab-org:main
• ef9d29ff - fix(ci get): do not require branch if pipelineID is given
• 688f4457 - fix: remove debug output

Compare with previous version

Rebased.

added 22 commits

• 688f4457...b43d277d - 20 commits from branch gitlab-org:main
• f2472464 - fix(ci get): do not require branch if pipelineID is given
• 1bf469ce - fix: remove debug output

Compare with previous version

added Leading Organization label

Hi @dmakovey. Do you still have the time to review this?

marked the checklist item Bug fix (non-breaking change which fixes an issue) as completed

@faleksic @ck3g this seems stuck. Can you review it?

requested review from @ck3g

Note for a maintainer

Steps to reproduce:

git checkout main
PIPELINE_ID=$(glab ci get | sed -n '/^[[:space:]]*id:/s/^[[:space:]]*id:[[:space:]]*//p')
git checkout HEAD^
glab ci get --pipeline-id $PIPELINE_ID

Before

→ glab ci get --pipeline-id $PIPELINE_ID
you're not on any Git branch (a 'detached HEAD' state).

After

→ glab ci get --pipeline-id $PIPELINE_ID
# Pipeline:
id:           1664921469
...

changed milestone to %17.9

approved this merge request

requested review from @viktomas

mentioned in issue gitlab-org/quality/triage-reports#22297 (closed)

approved this merge request

resolved all threads

started a merge train

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Reviewer	Maintainer
@faleksic (UTC+1)	@timofurrer (UTC+1)

Generated by Danger

merged

mentioned in commit b7da5851

Hi @abitrolly

See where you rank! Check your spot on the contributor leaderboard and unlock rewards.

---

How was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a or a on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

As a benefit of being a GitLab Community Contributor, you have access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.

Thanks for your help!

This message was generated automatically. Improve it or delete it.