Gitaly architectural/operational review of Stacked Diffs in the GitLab CLI
Timeline: Next 2-4 weeks (possibly 18.7 milestone)
Context
The Code Review team has built a working CLI prototype for stacked diffs and wants to move toward monolith integration. We need the Gitaly team's git expertise to review our current approach and guide the next steps.
Specific Review Requests
-
Code Review - Review the existing CLI implementation: https://gitlab.com/gitlab-org/cli/-/tree/main/internal/commands/stack?ref_type=heads
- Focus on how we're wrapping git commands
- Assess technical approach and identify gaps
-
Feedback Analysis - Review community feedback: #7473
- Understand user expectations and pain points
-
Epic Review - Review current open issues: &12025
- Understand scope and planned features
-
Demo Review - Watch functionality walkthrough: https://www.youtube.com/watch?v=TOQOV8PWYic
- Understand user experience we're targeting
Desired Outcomes
- Gap Analysis: What's missing from our current implementation?
- Architecture Guidance: What should be handled in CLI vs Gitaly vs monolith?
- Integration Strategy: Best approach for moving stack metadata to/from the monolith
- Git Optimization: Leverage your git expertise to improve our current git command wrapping
Focus: GitLab-specific implementation only (not building agnostic tooling)
Next Steps
Please review the materials above and provide feedback on:
- Technical gaps in the current implementation
- Recommended architecture for monolith integration
- Any additional Gitaly/git capabilities we should leverage
Edited by Kai Armstrong