glab release view and list use default gitlab repository
Remove usage of glinstance.OverridableDefault() in release commands, we should use the url returned by the API rather than try and construct the URL
commands/release/releaseutils/releaseutils.go:59: glinstance.OverridableDefaultProtocol(), glinstance.OverridableDefault(),
commands/release/view/view.go:107: glinstance.OverridableDefaultProtocol(), glinstance.OverridableDefault(),
Reproduce by being in a gdk repo with a default host of gitlab.com
glab release view v34.8
Displays incorrect url:
❯ glab release view v34.8
gitlab.com
v34.8
Administrator released this about 5 months ago
54a494b2 - v34.8
iii
ASSETS
There are no assets for this release
SOURCES
https://gdk.test:3443/flightjs/Flight/-/archive/v34.8/Flight-v34.8.zip
https://gdk.test:3443/flightjs/Flight/-/archive/v34.8/Flight-v34.8.tar.gz
https://gdk.test:3443/flightjs/Flight/-/archive/v34.8/Flight-v34.8.tar.bz2
https://gdk.test:3443/flightjs/Flight/-/archive/v34.8/Flight-v34.8.tar
View this release on GitLab at https://gitlab.com/flightjs/Flight/-/releases/v34.8
The following discussion from !1395 (closed) should be addressed:
-
@emersion started a discussion: (+10 comments) Thanks for the review!
It seems like there is an (unrelated) test failure…
Edited by Jay McCure