# Sprint 25: `make install` with Commit Embedding & Daemon Version Guard Add a `make install` target that embeds the current git commit into the binary. On every CLI invocation that talks to the daemon, check whether the running daemon was built from the same commit. If it differs, automatically restart the daemon so it always runs the same version as the CLI. **Problem**: During development (and after upgrades), the installed `glci` binary and the long-running daemon process can get out of sync. The user runs `make install`, gets a new CLI, but the daemon is still the old binary — potentially with different RPC endpoints, different mock server behavior, or different execution logic. This causes subtle, hard-to-debug failures. **Goal**: After `make install`, the next `glci` command transparently restarts the daemon if needed. The user never has to think about daemon version mismatches. ## Design ### 1. Embed Build Commit via `ldflags` Create a `pkg/version/version.go` with a `Commit` variable set at build time: ```go package version // Commit is the git commit hash the binary was built from. // Set via -ldflags at build time. Empty means "dev build". var Commit string ``` The Makefile sets it: ```makefile COMMIT := $(shell git rev-parse HEAD) LDFLAGS := -X gitlab.com/gngeorgiev/glci/pkg/version.Commit=$(COMMIT) .PHONY: install install: go install -ldflags "$(LDFLAGS)" ./cmd/glci ``` ### 2. Expose Commit in Daemon Health Endpoint The daemon's `/api/health` response already returns `pid`, `uptime`, and `active_pipelines`. Add a `commit` field: ```json { "pid": 12345, "uptime": "2h15m", "active_pipelines": 1, "commit": "abc123def456..." } ``` `NewDaemonServer()` reads `version.Commit` at startup and includes it in every health response. ### 3. Version Check in `EnsureRunning()` Before returning "daemon is already running", `EnsureRunning()` compares commits: ``` 1. Daemon is running (PID alive, socket responding) 2. Call /api/health → get daemon's commit 3. Compare with version.Commit (our own commit) 4. If they match → done, daemon is compatible 5. If they differ → restart the daemon: a. Stop the running daemon (graceful SIGTERM) b. Wait for shutdown (socket gone / PID gone) c. Start new daemon (same spawn logic as today) d. Wait for new daemon to be ready ``` **Edge cases**: - **Empty commit** (dev build without ldflags): skip the version check entirely. During `go run` or `go build` without `-ldflags`, `Commit` is `""`. Don't restart the daemon just because one or both sides are dev builds. - **Daemon doesn't have the commit field** (old daemon, pre-sprint-25): treat as mismatch and restart. This handles the one-time upgrade path. - **Active pipelines during restart**: the daemon has active work. Log a warning but still restart — version mismatches can cause worse problems than a restart. The daemon's graceful shutdown will attempt to clean up. Sprint 24's crash recovery (if implemented) would handle resume. - **Restart fails**: if the new daemon fails to start after stopping the old one, return the error. Don't leave the user with no daemon. ### 4. `glci version` Command Add a `version` subcommand that prints the embedded commit: ``` $ glci version glci commit abc123def456... $ glci version # dev build glci commit (dev) ``` Also show daemon version if running: ``` $ glci version glci commit abc123def456... daemon commit abc123def456... (pid 12345, up 2h15m) ``` Or if mismatched: ``` $ glci version glci commit abc123def456... daemon commit 789xyz... (pid 12345, up 2h15m) [VERSION MISMATCH] ``` ### 5. `daemon status` Enhancement Enhance `glci daemon status` to also show the commit: ``` daemon is running pid: 12345 uptime: 2h15m active pipelines: 1 commit: abc123def456... ``` ## Implementation Sequence | Step | Description | Key Files | Depends On | |------|-------------|-----------|------------| | 1 | Create `pkg/version/version.go` with `Commit` var | `pkg/version/version.go` | — | | 2 | Create Makefile with `install` target using ldflags | `Makefile` | 1 | | 3 | Add `commit` field to health endpoint response | `pkg/daemon/server.go` | 1 | | 4 | Version check + auto-restart in `EnsureRunning()` | `pkg/daemon/daemon.go` | 1, 3 | | 5 | Add `glci version` command | `cmd/glci/main.go` | 1, 3 | | 6 | Enhance `daemon status` to show commit | `cmd/glci/daemon.go` | 3 | | 7 | Tests for version mismatch detection and restart | `pkg/daemon/daemon_test.go` | 4 | | 8 | E2E test: install, start daemon, reinstall, verify restart | `e2e/version_test.go` | all | **Goal**: After this sprint, `make install` is the standard way to build and install glci. The daemon automatically stays in sync with the CLI binary — no manual `glci daemon stop` needed after upgrades.