Skip to content

Allow postgres to use a serviceName as well as a host #1458

Mike Rennie requested to merge org-ids/gitlab:Issue1458 into master

Here is a first cut at allowing for a PostgreSQL service name to be specified.

A couple of things:

  1. I noticed the psql host template does not coalesce the postgres info from unicorn / sidekiq / migrations values - not sure if thats intentional or not - or if it was intended to be more like the redis host template
  2. should the redis template be updated to also allow for a serviceName that does not include the release name?
  3. I updated the doc in the unicorn / sidekiq / migrations charts mentioning the psql service name, but it feels out of place since the template does not coalesce from the chart-specific values (unless I missed something)

Merge request reports