Gitaly subchart appVersion = "master" on release branch
Summary
all previous stable branches contain gitaly image versions, but the current release branch uses 'master' and therefore the latest image.
Steps to reproduce
Check 2-6-stable vs 2-5-stable.
Configuration used
Nothing interesting here.
Current behavior
The latest stable branch uses a "floating" tag (latest
) for the gitaly image. At our company this is an antipattern for production environments, as image pulls are not expected to be stable and therefore seemingly similar production environments may not have the same version of the code running.
Expected behavior
The latest stable branch uses a pinned image tag (e.g. v12.6.1
).
Backtrack
This is likely due to the version updater expecting a valid version number in the GITALY_SERVER_VERSION file in the gitlab-org/gitlab repository, but that contains a commit hash: a4b6c71d4b7c1588587345e2dfe0c6bd7cc63a83
. The version updater therefore uses the next best thing, which is master
.
GITALY_SERVER_VERSION containing a commit hash is new behaviour introduced in the gitlab bot, deployed at or before commit gitlab-org/gitlab@508c8ce1
Versions
- Chart: branch 2-6-stable
- Platform:
- Self-hosted: kops 1.15.0
- Kubernetes: (
kubectl version
)- Client: 1.17.0
- Server: 1.15.7
- Helm: (
helm version
)- Client: v2.14.0