Relocate global.gitlabVersion and global.edition to global.gitlab.x
The following discussion from !1008 (merged) should be addressed:
In reviewing this, however, I've had a thought cross my mind whilst considering this property & key location.
We should move this to
Allow me to explain. We're collecting a bunch of "one-off" settings (
enterpriseLicense) which are just spuriously present. They're all relative to GitLab, so I think if we implement
global.gitlab.license.*, we can then migrate
global.gitlabVersionunder this same property tree. Eventually, we'd have the following, which is think much clearer.
global: gitlab: edition: ee version: 12.4.1 license: secret: gitlab-ee-license
I'm not asking for the work on migrating the other two settings into this tree as a part of this MR, those would be good Maintenance P3 technical debt, great for getting developers introduced to the deprecations and checkConfig patterns.