Skip to content

release-tools: unable to pass only chart version

Summary

Our documentation on manual releases of this chart provides directions on how to "bump" a patch version for these charts by providing only that. This is non-functional.

We should enable this, as it is of great convenience, or simply remove that part of the documentation but provide the correct means to fetch the associated GitLab version (appVersion in Chart.yaml).

Steps to reproduce

bundle exec rake helm:tag_chart[2.3.8]

Current behavior

2019-10-21 10:44:19.387993 I ReleaseTools::Release::HelmGitlabRelease -- Update Chart version -- {:chart_version=>"2.3.8"}
rake aborted!
StandardError: /tmp/gitlab/scripts/lib/version.rb:16:in `initialize': no implicit conversion of nil into String (TypeError)
        from /tmp/gitlab/scripts/lib/version.rb:16:in `initialize'
        from /tmp/gitlab/scripts/lib/version_fetcher.rb:9:in `new'
        from /tmp/gitlab/scripts/lib/version_fetcher.rb:9:in `initialize'
        from ./scripts/manage_version.rb:168:in `new'
        from ./scripts/manage_version.rb:168:in `block in populate_subchart_versions'
        from ./scripts/manage_version.rb:167:in `map'
        from ./scripts/manage_version.rb:167:in `populate_subchart_versions'
        from ./scripts/manage_version.rb:128:in `initialize'
        from ./scripts/manage_version.rb:228:in `new'
        from ./scripts/manage_version.rb:228:in `<main>'
# New Versions
# version: 2.3.8
Reading /tmp/gitlab/charts/gitlab/charts/unicorn/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/task-runner/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/sidekiq/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/operator/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/migrations/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/mailroom/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/gitlab-shell/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/gitlab-grafana/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/gitlab-exporter/Chart.yaml
Reading /tmp/gitlab/charts/gitlab/charts/gitaly/Chart.yaml
/home/whse/code/release-tools/lib/release_tools/release/helm_gitlab_release.rb:120:in `block in run_update_version'
/home/whse/code/release-tools/lib/release_tools/release/helm_gitlab_release.rb:113:in `chdir'
/home/whse/code/release-tools/lib/release_tools/release/helm_gitlab_release.rb:113:in `run_update_version'
/home/whse/code/release-tools/lib/release_tools/release/helm_gitlab_release.rb:94:in `bump_version'
/home/whse/code/release-tools/lib/release_tools/release/helm_gitlab_release.rb:77:in `bump_versions'
/home/whse/code/release-tools/lib/release_tools/release/helm_gitlab_release.rb:47:in `execute_release'

Expected behavior

ReleaseTools::Release::HelmGitlabRelease -- Pushing ref to remote

Versions

  • Chart:
    • master @ 09732084
    • stable branches (at least since 2.1.x

cc @twk3 @WarheadsSE