Chart validation does not take consolidated object storage config into account
<!--NOTICE: This Issue tracker is for the GitLab Helm chart, not the GitLab Rails application. Support: Please do not raise support issues for GitLab.com on this tracker. See https://about.gitlab.com/support/--> ## Summary When attempting to upgrade from chart v9 to v10 (via the openshift operator, but I don't believe that is relevant), I get errors regarding bundled object storage (see logs below). However bundled object storage has never been enabled in our values. We do use the consolidated configuration to specify a secret/key for external storage as per https://docs.gitlab.com/charts/charts/globals/#consolidated-object-storage and I believe the new validation in`templates/_checkConfig_object_storage.tpl` is not taking that into account. ## Steps to reproduce Have working chart v9 configuration using consolidated object store secret/key. Minio not enabled. Upgrade to v10. ## Configuration used ```yaml global: appConfig: object_store: connection: key: s3-key secret: my-secret enabled: true proxy_download: true pages: enabled: true host: 'my-host' objectStore: bucket: my-pages-bucket ``` ## Current behavior Validation errors as per logs below ## Expected behavior Successful upgrade ## Versions - Chart: 10.0.1 - Platform: - Self-hosted: OpenShift - Kubernetes: (`kubectl version`) - Client: v1.31.14 - Server: v1.31.14 - Helm: (`helm version`) - Client: embedded in openshift - Server: embedded in openshift ## Relevant logs ``` Pages Object Storage:\n The chart provides no longer bundled object storage solution. Please\n prepare an external object storage solution for Pages by following\n https://docs.gitlab.com/charts/advanced/external-object-storage Backup Object Storage:\n The chart provides no longer bundled object storage solution. Please\n prepare an external object storage solution for backup and restore by following\n https://docs.gitlab.com/charts/advanced/external-object-storage/#backups ```
issue